Skip to content

Change getThis() into ZEND_THIS where possible #13641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2024
Merged

Change getThis() into ZEND_THIS where possible #13641

merged 1 commit into from
Mar 8, 2024

Conversation

@ndossche
Copy link
Member

@ndossche ndossche commented Mar 8, 2024

No description provided.

arnaud-lb
arnaud-lb approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@arnaud-lb arnaud-lb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ndossche ndossche merged commit 700fbca into php:master Mar 8, 2024
@ndossche ndossche deleted the getthis branch March 8, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arnaud-lb arnaud-lb arnaud-lb approved these changes

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

@iluuu1994 iluuu1994 Awaiting requested review from iluuu1994

Assignees

No one assigned

Labels

Category: Engine Extension: com_dotnet Extension: reflection Extension: sqlite3 Extension: zend_test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ndossche @arnaud-lb